linux-kernel - Re: [PATCH] drivers/misc: ti-st: remove redundant assignment to variable i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200111200136.GC438314@kroah.com>
Date:   Sat, 11 Jan 2020 21:01:36 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Colin King <colin.king@...onical.com>,
        Arnd Bergmann <arnd@...db.de>, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/misc: ti-st: remove redundant assignment to
 variable i

On Tue, Dec 03, 2019 at 10:28:24AM +0300, Dan Carpenter wrote:
> On Mon, Dec 02, 2019 at 03:13:52PM +0000, Colin King wrote:
> > From: Colin Ian King <colin.king@...onical.com>
> > 
> > The variable i is being initialized with a value that is never
> > read and it is being updated later with a new value in a for-loop.
> > The initialization is redundant and can be removed.
> > 
> > Addresses-Coverity: ("Unused value")
> > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> > ---
> >  drivers/misc/ti-st/st_core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c
> > index 2ae9948a91e1..6255d9b88122 100644
> > --- a/drivers/misc/ti-st/st_core.c
> > +++ b/drivers/misc/ti-st/st_core.c
> > @@ -736,7 +736,7 @@ static int st_tty_open(struct tty_struct *tty)
> >  
> >  static void st_tty_close(struct tty_struct *tty)
> >  {
> > -	unsigned char i = ST_MAX_CHANNELS;
> > +	unsigned char i;
> >  	unsigned long flags = 0;
> 
> I'm surprised that flags doesn't generate a warning as well.

Yes, flags should be not initialized as well.

Colin, can you resend a v2 with that added?

thanks,

greg k-h