linux-kernel - Re: [PATCH kselftest-next 1/2] kselftests: memcg: update the oom group leaf events test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191203165758.GA607734@chrisdown.name>
Date:   Tue, 3 Dec 2019 11:57:58 -0500
From:   Chris Down <chris@...isdown.name>
To:     Roman Gushchin <guro@...com>
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-team@...com, Johannes Weiner <hannes@...xchg.org>
Subject: Re: [PATCH kselftest-next 1/2] kselftests: memcg: update the oom
 group leaf events test

Roman Gushchin writes:
>Commit 9852ae3fe529 ("mm, memcg: consider subtrees in memory.events") made
>memory.events recursive: all events are propagated upwards by the
>tree. It was a change in semantics.
>
>It broke the oom group leaf events test: it assumes that after
>an OOM the oom_kill counter is zero on parent's level.
>
>Let's adjust the test: it should have similar expectations
>for the child and parent levels.
>
>The test passes after this fix.

Thanks! Hopefully b59b1baa will also avoid this going unnoticed in future.

Reviewed-by: Chris Down <chris@...isdown.name>