linux-kernel - Re: [PATCH kselftest-next 2/2] kselftests: memcg: speed up the memory.high test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191203165847.GB607734@chrisdown.name>
Date:   Tue, 3 Dec 2019 11:58:47 -0500
From:   Chris Down <chris@...isdown.name>
To:     Roman Gushchin <guro@...com>
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-team@...com, Johannes Weiner <hannes@...xchg.org>
Subject: Re: [PATCH kselftest-next 2/2] kselftests: memcg: speed up the
 memory.high test

Roman Gushchin writes:
>After commit 0e4b01df8659 ("mm, memcg: throttle allocators when
>failing reclaim over memory.high") allocating memory over memory.high
>became very time consuming. But it's exactly what the memory.high
>test from cgroup kselftests is doing: it tries to allocate 100M with
>30M memory.high value. It takes forever to complete.
>
>In order to keep it passing (or failing) in a reasonable amount of
>time let's try to allocate only a little over 30M: 31M to be precise.
>
>With this change test_memcontrol finishes in a reasonable amount of
>time:
>  $ time ./test_memcontrol
>  ok 1 test_memcg_subtree_control
>  ok 2 test_memcg_current
>  ok 3 test_memcg_min
>  ok 4 test_memcg_low
>  ok 5 test_memcg_high
>  ok 6 test_memcg_max
>  ok 7 test_memcg_oom_events
>  ok 8 test_memcg_swap_max
>  ok 9 test_memcg_sock
>  ok 10 test_memcg_oom_group_leaf_events
>  ok 11 test_memcg_oom_group_parent_events
>  ok 12 test_memcg_oom_group_score_events
>
>  real	0m2.273s
>  user	0m0.064s
>  sys	0m0.739s
>
>Signed-off-by: Roman Gushchin <guro@...com>
>Cc: Chris Down <chris@...isdown.name>
>Cc: Johannes Weiner <hannes@...xchg.org>

Thanks, this makes sense.

Reviewed-by: Chris Down <chris@...isdown.name>