linux-kernel - Re: [Patch v2 2/3] iommu: optimize iova_magazine_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpUC0v=0BETLP0=9O89g38Crx5pMB9jcvx3cEkafT+vUkg@mail.gmail.com>
Date:   Tue, 3 Dec 2019 11:28:24 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     iommu@...ts.linux-foundation.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [Patch v2 2/3] iommu: optimize iova_magazine_free_pfns()

On Mon, Dec 2, 2019 at 8:59 AM Christoph Hellwig <hch@...radead.org> wrote:
>
> > +     return (mag && mag->size == IOVA_MAG_SIZE);
>
> > +     return (!mag || mag->size == 0);
>
> No need for the braces in both cases.

The current code is already this, I don't want to mix coding style
changes with a non-coding-style change. You can always remove
them in a separated patch if you feel necessary.

Thanks.