linux-kernel - RE: [PATCH v2 2/2] gpio: bcm-kona: use platform_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM0PR04MB4481D76A9779C2DA7B1331C3885D0@AM0PR04MB4481.eurprd04.prod.outlook.com>
Date:   Wed, 4 Dec 2019 08:41:14 +0000
From:   Peng Fan <peng.fan@....com>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
CC:     "rjui@...adcom.com" <rjui@...adcom.com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "sbranden@...adcom.com" <sbranden@...adcom.com>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "robh@...nel.org" <robh@...nel.org>,
        "bcm-kernel-feedback-list@...adcom.com" 
        <bcm-kernel-feedback-list@...adcom.com>,
        dl-linux-imx <linux-imx@....com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Alice Guo <alice.guo@....com>
Subject: RE: [PATCH v2 2/2] gpio: bcm-kona: use platform_irq_count

> Subject: Re: [PATCH v2 2/2] gpio: bcm-kona: use platform_irq_count
> 
> On Wed, Dec 04, 2019 at 04:20:45AM +0000, Peng Fan wrote:
> > From: Peng Fan <peng.fan@....com>
> >
> > platform_irq_count() is the more generic way (independent of device
> > trees) to determine the count of available interrupts. So use this
> > instead.
> >
> > As platform_irq_count() might return an error code (which of_irq_count
> > doesn't) some additional handling is necessary.
> >
> > Signed-off-by: Peng Fan <peng.fan@....com>
> > ---
> >
> > V2:
> >  Update commit log, and add err handling  Not tested, just code
> > inspection
> >
> >  drivers/gpio/gpio-bcm-kona.c | 12 +++++++++---
> >  1 file changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-bcm-kona.c
> > b/drivers/gpio/gpio-bcm-kona.c index 4122683eb1f9..52ff56166263
> 100644
> > --- a/drivers/gpio/gpio-bcm-kona.c
> > +++ b/drivers/gpio/gpio-bcm-kona.c
> > @@ -19,7 +19,6 @@
> >  #include <linux/io.h>
> >  #include <linux/gpio/driver.h>
> >  #include <linux/of_device.h>
> > -#include <linux/of_irq.h>
> >  #include <linux/init.h>
> >  #include <linux/irqdomain.h>
> >  #include <linux/irqchip/chained_irq.h> @@ -586,11 +585,18 @@ static
> > int bcm_kona_gpio_probe(struct platform_device *pdev)
> >
> >  	kona_gpio->gpio_chip = template_chip;
> >  	chip = &kona_gpio->gpio_chip;
> > -	kona_gpio->num_bank = of_irq_count(dev->of_node);
> > -	if (kona_gpio->num_bank == 0) {
> > +	ret = platform_irq_count(pdev);
> > +	if (!ret) {
> >  		dev_err(dev, "Couldn't determine # GPIO banks\n");
> >  		return -ENOENT;
> > +	} else if (ret < 0) {
> > +		if (ret != -EPROBE_DEFER)
> > +			dev_err(dev, "Couldn't determine GPIO banks: %d\n",
> > +				ret);
> 
> You can use the new %pe feature here:

Checkpatch reports warning:

WARNING: Invalid vsprintf pointer extension '%pe'
#49: FILE: drivers/gpio/gpio-bcm-kona.c:593:
+               if (ret != -EPROBE_DEFER)
+                       dev_err(dev, "Couldn't determine GPIO banks: (%pe)\n",
+                               ERR_PTR(ret));

Thanks,
Peng.

> 
> 	dev_err(dev, "Couldn't determine GPIO banks: %pe\n",
> 		ERR_PTR(ret));
> 
> > +		return ret;
> >  	}
> > +	kona_gpio->num_bank = ret;
> > +
> 
> Looks otherwise ok.
> 
> Best regards
> Uwe
> 
> --
> Pengutronix e.K.                           | Uwe Kleine-König
> |
> Industrial Linux Solutions                 |
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.
> pengutronix.de%2F&amp;data=02%7C01%7Cpeng.fan%40nxp.com%7C8c566
> 59ba01b4b5db43608d7788b77fa%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0%7C0%7C637110412715339679&amp;sdata=MDjn8C9mtDqZCN01nOT
> KhVJoLiqPue8In5v5OT91B6Y%3D&amp;reserved=0 |