linux-kernel - Re: [PATCH] zram: fix error return codes not being returned in writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191204011628.GA6629@google.com>
Date:   Tue, 3 Dec 2019 17:16:28 -0800
From:   Minchan Kim <minchan@...nel.org>
To:     Colin King <colin.king@...onical.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Nitin Gupta <ngupta@...are.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-block@...r.kernel.org
Subject: Re: [PATCH] zram: fix error return codes not being returned in
 writeback_store

On Thu, Nov 28, 2019 at 12:29:58PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently when an error code -EIO or -ENOSPC in the for-loop of
> writeback_store the error code is being overwritten by a ret = len
> assignment at the end of the function and the error codes are being
> lost.  Fix this by assigning ret = len at the start of the function
> and remove the assignment from the end, hence allowing ret to be
> preserved when error codes are assigned to it.
> 
> Addresses-Coverity: ("Unused value")
> Fixes: a939888ec38b ("zram: support idle/huge page writeback")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
Acked-by: Minchan Kim <minchan@...nel.org>

Thanks!