linux-kernel - Re: [PATCH v2 0/3] perf report: Few fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191204120707.GC20746@krava>
Date:   Wed, 4 Dec 2019 13:07:07 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
Cc:     acme@...nel.org, kan.liang@...el.com, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, namhyung@...nel.org,
        ak@...ux.intel.com, yao.jin@...ux.intel.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] perf report: Few fixes

On Thu, Nov 14, 2019 at 06:52:10PM +0530, Ravi Bangoria wrote:
> v1: https://lore.kernel.org/r/20191112054946.5869-1-ravi.bangoria@linux.ibm.com
> 
> v1 fixed a segfault when -F phys_daddr is used in perf report without
> --mem-mode. Arnaldo suggested to bail out the option completely in
> such case instead of showing 0 values.
> 
> Ravi Bangoria (3):
>   perf hists: Replace pr_err with ui__error
>   perf report: Make -F more strict like -s
>   perf report: Error out for mem mode fields if mem info is not
>     available
> 
>  tools/perf/builtin-report.c |  8 ++++++++
>  tools/perf/util/sort.c      | 16 +++++++++++-----
>  2 files changed, 19 insertions(+), 5 deletions(-)

looks good

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka