linux-kernel - Re: [PATCH] scsi: ufs: Disable autohibern8 feature in Cadence UFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38cfe842-c07a-410f-97f1-f2bf13fd2655@ti.com>
Date:   Wed, 4 Dec 2019 19:06:09 +0530
From:   Vignesh Raghavendra <vigneshr@...com>
To:     sheebab <sheebab@...ence.com>, <alim.akhtar@...sung.com>,
        <avri.altman@....com>, <pedrom.sousa@...opsys.com>,
        <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>,
        <stanley.chu@...iatek.com>, <beanhuo@...ron.com>,
        <yuehaibing@...wei.com>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     <mparab@...ence.com>, <rafalc@...ence.com>
Subject: Re: [PATCH] scsi: ufs: Disable autohibern8 feature in Cadence UFS



On 03/12/19 3:37 pm, sheebab wrote:
> This patch disables autohibern8 feature in Cadence UFS. 
> The autohibern8 feature has issues due to which unexpected interrupt
> trigger is happening. After the interrupt issue is sorted out autohibern8
> feature will be re-enabled
> 
> Signed-off-by: sheebab <sheebab@...ence.com>
> ---

Tested-by: Vignesh Raghavendra <vigneshr@...com>

You will have to repost patch 2/2[1] of your previous series as that
patch no longer applies cleanly anymore given that we no longer want 1/2
to be merged.

[1]
https://lore.kernel.org/linux-scsi/1574147082-22725-3-git-send-email-sheebab@cadence.com/


>  drivers/scsi/ufs/cdns-pltfrm.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/scsi/ufs/cdns-pltfrm.c b/drivers/scsi/ufs/cdns-pltfrm.c
> index b2af04c57a39..882425d1166b 100644
> --- a/drivers/scsi/ufs/cdns-pltfrm.c
> +++ b/drivers/scsi/ufs/cdns-pltfrm.c
> @@ -98,6 +98,12 @@ static int cdns_ufs_link_startup_notify(struct ufs_hba *hba,
>  	 * completed.
>  	 */
>  	ufshcd_dme_set(hba, UIC_ARG_MIB(PA_LOCAL_TX_LCC_ENABLE), 0);
> +
> +	/*
> +	 * Disabling Autohibern8 feature in cadence UFS
> +	 * to mask unexpected interrupt trigger.
> +	 */
> +	hba->ahit = 0;
>  
>  	return 0;
>  }
> 

-- 
Regards
Vignesh