linux-kernel - Re: [PATCH V2] media: ov5640: Fix check for PLL1 exceeding max allowed rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 Dec 2019 07:37:43 -0600
From:   Adam Ford <aford173@...il.com>
To:     Jacopo Mondi <jacopo@...ndi.org>
Cc:     linux-media <linux-media@...r.kernel.org>,
        Adam Ford <adam.ford@...icpd.com>,
        Steve Longerbeam <slongerbeam@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] media: ov5640: Fix check for PLL1 exceeding max
 allowed rate

On Wed, Dec 4, 2019 at 7:23 AM Jacopo Mondi <jacopo@...ndi.org> wrote:
>
> Hi Adam,
>
> On Wed, Dec 04, 2019 at 07:09:07AM -0600, Adam Ford wrote:
> > The PLL calculation routine checks the wrong variable name 'rate'
> > when it should be called '_rate' when checking to see whether or
> > not the PLL1 output frequency exceeds 1GHz.
> >
> > This patch changes it to the correct variable '_rate'
> >
> > Acked-by: Jacopo Mondi <jacopo@...ndi.org>
> > Signed-off-by: Adam Ford <aford173@...il.com>
>
> Why have you dropped the fixes tag you had in v1?
>
> Fixes: aa2882481cad ("media: ov5640: Adjust the clock based on the expected rate")
>
> I'm not the one who collects patches, so maybe wait for Sakari or Hans
> to tell you if you need to resend or not :)

It wasn't intentional.  I couldn't find the original patch nor could I
find it in patchwork, so I re-did it from scratch and forgot.
(I have too many different computers)

I already sent a V3 before I read your e-mail.  Sorry about that.

adam

>
> Thanks
>    j
>
> > ---
> > V2:  No code change.  Only change commit description to be less confusing.
> >
> > diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> > index 5e495c833d32..bb968e764f31 100644
> > --- a/drivers/media/i2c/ov5640.c
> > +++ b/drivers/media/i2c/ov5640.c
> > @@ -874,7 +874,7 @@ static unsigned long ov5640_calc_sys_clk(struct ov5640_dev *sensor,
> >                        * We have reached the maximum allowed PLL1 output,
> >                        * increase sysdiv.
> >                        */
> > -                     if (!rate)
> > +                     if (!_rate)
> >                               break;
> >
> >                       /*
> > --
> > 2.20.1
> >