linux-kernel - Re: [PATCH] tty: serial: samsung: support driver modulization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191206064020.GA1318959@kroah.com>
Date:   Fri, 6 Dec 2019 07:40:20 +0100
From:   'Greg KH' <gregkh@...uxfoundation.org>
To:     ������/HYUN-KI KOO 
        <hyunki00.koo@...sung.com>
Cc:     'Krzysztof Kozlowski' <krzk@...nel.org>,
        'Hyunki Koo' <kkoos00@...er.com>, jslaby@...e.com,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        kkoos00@...il.com, 'Shinbeom Choi' <sbeom.choi@...sung.com>
Subject: Re: [PATCH] tty: serial: samsung: support driver modulization


A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Fri, Dec 06, 2019 at 10:44:20AM +0900, ������/HYUN-KI KOO wrote:
> To support module for Samsung serial driver,
> I would like to split the file into 2 files.

But you did not do that here in this patch, right?

> Because it cannot be supported in one file both early console and
> module driver
> Thus some function need to change to EXPORT_SYMBOL to use in module
> driver file.
> I'm not pushed yet for module driver.

I do not understand, this patch feels wrong and incomplete as-is, right?
Please fix it up to work properly.

thanks,

greg k-h