linux-kernel - Re: [PATCH] tty: serial: samsung: support driver modulization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPddtiVVsCd-RUB=HboxSRxmN86uwRYuR_-JZYSYd=cJQg@mail.gmail.com>
Date:   Fri, 6 Dec 2019 09:09:27 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     구현기/HYUN-KI KOO <hyunki00.koo@...sung.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Hyunki Koo <kkoos00@...er.com>, jslaby@...e.com,
        linux-serial@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kkoos00@...il.com, Shinbeom Choi <sbeom.choi@...sung.com>
Subject: Re: [PATCH] tty: serial: samsung: support driver modulization

On Fri, 6 Dec 2019 at 02:44, 구현기/HYUN-KI KOO <hyunki00.koo@...sung.com> wrote:
>
> To support module for Samsung serial driver,
> I would like to split the file into 2 files.
> Because it cannot be supported in one file both early console and
> module driver
> Thus some function need to change to EXPORT_SYMBOL to use in module
> driver file.
> I'm not pushed yet for module driver.

Hi,

You sent few patches independently of each other. If we did not ask,
we would not get the idea why you need them. This is not how the Linux
kernel development works. Instead, start preparing a proper patchset
to achieve your goal. This patchset will contain multiple patches. It
should go with a cover letter (see git format-patch) explaining why
you do it. This way reviewers will know the big picture. The entire
work should not break existing systems (see comments for IRQ combiner
or pinctrl). You should consider how your change will affect existing
systems.

Best regards,
Krzysztof