[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20191207.115922.532322440743611081.davem@davemloft.net>
Date: Sat, 07 Dec 2019 11:59:22 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: ms@....tdt.de
Cc: andrew.hendry@...il.com, edumazet@...gle.com,
linux-x25@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/x25: add new state X25_STATE_5
From: Martin Schiller <ms@....tdt.de>
Date: Fri, 6 Dec 2019 14:34:18 +0100
> + switch (frametype) {
> +
> + case X25_CLEAR_REQUEST:
Please remove this unnecessary empty line.
> + if (!pskb_may_pull(skb, X25_STD_MIN_LEN + 2))
> + goto out_clear;
A goto path for a single call site? Just inline the operations here.
Powered by blists - more mailing lists