linux-kernel - Re: [PATCH v1 1/2] soc: mediatek: add header for SiP service interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1575783443.12066.1.camel@mtkswgap22>
Date:   Sun, 8 Dec 2019 13:37:23 +0800
From:   Stanley Chu <stanley.chu@...iatek.com>
To:     Florian Fainelli <f.fainelli@...il.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "avri.altman@....com" <avri.altman@....com>,
        "alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
        "pedrom.sousa@...opsys.com" <pedrom.sousa@...opsys.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        Leon Chen (陳文鏘) 
        <Leon.Chen@...iatek.com>,
        "Andy Teng ( .$B{}G!9(.(B)" 
        <Andy.Teng@...iatek.com>,
        Chun-Hung Wu (巫駿宏) 
        <Chun-hung.Wu@...iatek.com>,
        Kuohong Wang (王國鴻) 
        <kuohong.wang@...iatek.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Peter Wang (王信友) 
        <peter.wang@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>
Subject: Re: [PATCH v1 1/2] soc: mediatek: add header for SiP service
 interface

Hi Florian,

On Sun, 2019-12-08 at 01:40 +0800, Florian Fainelli wrote:

> > +#ifdef CONFIG_ARM64
> > +#define MTK_SIP_SMC_AARCH_BIT           0x40000000
> > +#else
> > +#define MTK_SIP_SMC_AARCH_BIT           0x00000000
> > +#endif
> 
> Cannot you use the definitions from include/linux/arm-smccc.h and use
> ARM_SMCCC_CALL_CONV_SHIFT here and associated helpers?
> 
> > +
> > +/* UFS related SMC call */
> > +#define MTK_SIP_UFS_CONTROL \
> > +	(0x82000276 | MTK_SIP_SMC_AARCH_BIT)
> 
> Does bit 31 map to the fast vs. slow call of the ARM SMCCC convention or
> does it have a different meaning (should not). Likewise bit 25 would be
> ARM_SMMCCC_OWNER_SIP no?
> 
> That would leave us with only 0x276 which is a valid function number.

Thanks so much for these comments.
I'll try to use suitable definitions instead in next version.

Stanley