linux-kernel - Re: [PATCH] devfreq: move declaration of DEVICE_ATTR_RW(min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c2b9991e-212c-5ba5-a160-36d698e31bee@samsung.com>
Date:   Mon, 9 Dec 2019 12:25:32 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Kamil Konieczny <k.konieczny@...sung.com>
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>
Subject: Re: [PATCH] devfreq: move declaration of DEVICE_ATTR_RW(min_freq)

Hi Kamil,

Looks good to me. Applied it.

On later, better to add 'PM / ' prefix for patch title
and use capital char for first word as following:

devfreq: move declaration of DEVICE_ATTR_RW(min_freq)
-> PM / devfreq: Move declaration of DEVICE_ATTR_RW(min_freq)

On 12/6/19 7:11 PM, Kamil Konieczny wrote:
> Declaration of DEVICE_ATTR_RW(min_freq) is placed after function
> max_freq_store. Move it to the correct place after min_freq_show.
> 
> Signed-off-by: Kamil Konieczny <k.konieczny@...sung.com>
> ---
>  drivers/devfreq/devfreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 1786a86b1779..46a7ff7c2994 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -1368,6 +1368,7 @@ static ssize_t min_freq_show(struct device *dev, struct device_attribute *attr,
>  
>  	return sprintf(buf, "%lu\n", min_freq);
>  }
> +static DEVICE_ATTR_RW(min_freq);
>  
>  static ssize_t max_freq_store(struct device *dev, struct device_attribute *attr,
>  			      const char *buf, size_t count)
> @@ -1391,7 +1392,6 @@ static ssize_t max_freq_store(struct device *dev, struct device_attribute *attr,
>  
>  	return count;
>  }
> -static DEVICE_ATTR_RW(min_freq);
>  
>  static ssize_t max_freq_show(struct device *dev, struct device_attribute *attr,
>  			     char *buf)
> 


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics