[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20191209162234.GC5483@sirena.org.uk>
Date: Mon, 9 Dec 2019 16:22:34 +0000
From: Mark Brown <broonie@...nel.org>
To: Chuhong Yuan <hslester96@...il.com>
Cc: Brian Austin <brian.austin@...rus.com>,
Paul Handrigan <Paul.Handrigan@...rus.com>,
Liam Girdwood <lgirdwood@...il.com>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: cs35l32: add missed regulator_bulk_disable in
remove
On Fri, Dec 06, 2019 at 03:51:46PM +0800, Chuhong Yuan wrote:
> @@ -501,6 +501,8 @@ static int cs35l32_i2c_remove(struct i2c_client *i2c_client)
> /* Hold down reset */
> gpiod_set_value_cansleep(cs35l32->reset_gpio, 0);
>
> + regulator_bulk_disable(ARRAY_SIZE(cs35l32->supplies),
> + cs35l32->supplies);
This is a similar situation to the one Charles pointed out - the driver
is using runtime PM to manage the regulators so unless the device is
active when removed the regulators won't be enabled.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists