linux-kernel - Re: [PATCH] NFC: nxp-nci: Fix probing without ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Dec 2019 21:16:33 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Stephan Gerhold <stephan@...hold.net>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Clément Perrochaud 
        <clement.perrochaud@...innov.com>,
        Charles Gorand <charles.gorand@...innov.com>,
        linux-nfc@...ts.01.org, netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH] NFC: nxp-nci: Fix probing without ACPI

On Mon, Dec 9, 2019 at 8:57 PM Stephan Gerhold <stephan@...hold.net> wrote:
>
> devm_acpi_dev_add_driver_gpios() returns -ENXIO if CONFIG_ACPI
> is disabled (e.g. on device tree platforms).
> In this case, nxp-nci will silently fail to probe.
>
> The other NFC drivers only log a debug message if
> devm_acpi_dev_add_driver_gpios() fails.
> Do the same in nxp-nci to fix this problem.
>

Ah, thanks!
Acked-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Fixes: ad0acfd69add ("NFC: nxp-nci: Get rid of code duplication in ->probe()")
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Signed-off-by: Stephan Gerhold <stephan@...hold.net>
> ---
>  drivers/nfc/nxp-nci/i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nfc/nxp-nci/i2c.c b/drivers/nfc/nxp-nci/i2c.c
> index 4d1909aecd6c..9f60e4dc5a90 100644
> --- a/drivers/nfc/nxp-nci/i2c.c
> +++ b/drivers/nfc/nxp-nci/i2c.c
> @@ -278,7 +278,7 @@ static int nxp_nci_i2c_probe(struct i2c_client *client,
>
>         r = devm_acpi_dev_add_driver_gpios(dev, acpi_nxp_nci_gpios);
>         if (r)
> -               return r;
> +               dev_dbg(dev, "Unable to add GPIO mapping table\n");
>
>         phy->gpiod_en = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
>         if (IS_ERR(phy->gpiod_en)) {
> --
> 2.24.0
>


-- 
With Best Regards,
Andy Shevchenko