linux-kernel - Re: [PATCH] NFC: nxp-nci: Fix probing without ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191209.201649.404230474226196154.davem@davemloft.net>
Date:   Mon, 09 Dec 2019 20:16:49 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     stephan@...hold.net
Cc:     clement.perrochaud@...innov.com, charles.gorand@...innov.com,
        linux-nfc@...ts.01.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, andriy.shevchenko@...ux.intel.com
Subject: Re: [PATCH] NFC: nxp-nci: Fix probing without ACPI

From: Stephan Gerhold <stephan@...hold.net>
Date: Mon,  9 Dec 2019 19:53:43 +0100

> devm_acpi_dev_add_driver_gpios() returns -ENXIO if CONFIG_ACPI
> is disabled (e.g. on device tree platforms).
> In this case, nxp-nci will silently fail to probe.
> 
> The other NFC drivers only log a debug message if
> devm_acpi_dev_add_driver_gpios() fails.
> Do the same in nxp-nci to fix this problem.
> 
> Fixes: ad0acfd69add ("NFC: nxp-nci: Get rid of code duplication in ->probe()")
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Signed-off-by: Stephan Gerhold <stephan@...hold.net>

Applied and queued up for v5.4 -stable, thanks.