linux-kernel - Re: [PATCH] drm: msm: mdp4: Adjust indentation in mdp4_dsi_encoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKwvOdkeCCuYDWQFHitFczFX1-R1LjWoJ2gAfLuQAqvGz0ymPg@mail.gmail.com>
Date:   Mon, 9 Dec 2019 12:52:40 -0800
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        freedreno@...ts.freedesktop.org,
        LKML <linux-kernel@...r.kernel.org>,
        clang-built-linux <clang-built-linux@...glegroups.com>
Subject: Re: [PATCH] drm: msm: mdp4: Adjust indentation in mdp4_dsi_encoder_enable

On Mon, Dec 9, 2019 at 12:32 PM Nathan Chancellor
<natechancellor@...il.com> wrote:
>
> Clang warns:
>
> ../drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c:124:3: warning:
> misleading indentation; statement is not part of the previous 'if'
> [-Wmisleading-indentation]
>          mdp4_crtc_set_config(encoder->crtc,
>          ^
> ../drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c:121:2: note:
> previous statement is here
>         if (mdp4_dsi_encoder->enabled)
>         ^
>
> This warning occurs because there is a space after the tab on this line.
> Remove it so that the indentation is consistent with the Linux kernel
> coding style and clang no longer warns.

Thanks for the cleanup. Nothing to see here, but should help us find
more interesting cases.
Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>
(If there are other instances in drivers/gpu/drm/msm, they should be
rolled up into this commit)

>
> Fixes: 776638e73a19 ("drm/msm/dsi: Add a mdp4 encoder for DSI")
> Link: https://github.com/ClangBuiltLinux/linux/issues/792
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
>  drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c
> index 772f0753ed38..aaf2f26f8505 100644
> --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c
> @@ -121,7 +121,7 @@ static void mdp4_dsi_encoder_enable(struct drm_encoder *encoder)
>         if (mdp4_dsi_encoder->enabled)
>                 return;
>
> -        mdp4_crtc_set_config(encoder->crtc,
> +       mdp4_crtc_set_config(encoder->crtc,
>                         MDP4_DMA_CONFIG_PACK_ALIGN_MSB |
>                         MDP4_DMA_CONFIG_DEFLKR_EN |
>                         MDP4_DMA_CONFIG_DITHER_EN |
> --
> 2.24.0
>
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20191209203230.1593-1-natechancellor%40gmail.com.



-- 
Thanks,
~Nick Desaulniers