linux-kernel - RE: [PATCH v1 3/4] arm64: dts: ls1028a: fix little-big endian issue for dcfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Dec 2019 02:34:30 +0000
From:   "Y.b. Lu" <yangbo.lu@....com>
To:     Shawn Guo <shawnguo@...nel.org>
CC:     Ashish Kumar <ashish.kumar@....com>,
        Alexandru Marginean <alexandru.marginean@....com>,
        Alison Wang <alison.wang@....com>,
        "Amit Jain (aj)" <amit.jain_1@....com>,
        "catalin.horghidan@....com" <catalin.horghidan@....com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Jiafei Pan <jiafei.pan@....com>, Leo Li <leoyang.li@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "rajat.srivastava@....com" <rajat.srivastava@....com>,
        Rajesh Bhagat <rajesh.bhagat@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        Vabhav Sharma <vabhav.sharma@....com>,
        Xiaobo Xie <xiaobo.xie@....com>,
        Michael Walle <michael@...le.cc>, Yinbo Zhu <yinbo.zhu@....com>
Subject: RE: [PATCH v1 3/4] arm64: dts: ls1028a: fix little-big endian issue
 for dcfg

+ Shawn,

> -----Original Message-----
> From: Michael Walle <michael@...le.cc>
> Sent: Tuesday, December 10, 2019 8:06 AM
> To: Yinbo Zhu <yinbo.zhu@....com>
> Cc: Ashish Kumar <ashish.kumar@....com>; Alexandru Marginean
> <alexandru.marginean@....com>; Alison Wang <alison.wang@....com>;
> Amit Jain (aj) <amit.jain_1@....com>; catalin.horghidan@....com; Claudiu
> Manoil <claudiu.manoil@....com>; devicetree@...r.kernel.org; Jiafei Pan
> <jiafei.pan@....com>; Leo Li <leoyang.li@....com>;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> linuxppc-dev@...ts.ozlabs.org; mark.rutland@....com;
> rajat.srivastava@....com; Rajesh Bhagat <rajesh.bhagat@....com>;
> robh+dt@...nel.org; Vabhav Sharma <vabhav.sharma@....com>; Xiaobo Xie
> <xiaobo.xie@....com>; Y.b. Lu <yangbo.lu@....com>; Michael Walle
> <michael@...le.cc>
> Subject: Re: [PATCH v1 3/4] arm64: dts: ls1028a: fix little-big endian issue for
> dcfg
> 

[Y.b. Lu] Acked-by: Yangbo Lu <yangbo.lu@....com>

Hi Shawn, could you help to review and merge the two dts patches of this patch-set?
Thanks.

> > dcfg use little endian that SoC register value will be correct
> >
> > Signed-off-by: Yinbo Zhu <yinbo.zhu@....com>
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> This patch is still missing. Any news?
> 
> Tested-by: Michael Walle <michael@...le.cc>
> 
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index b0d4f8916ede..5538e8e354b2 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -162,7 +162,7 @@
> >  		dcfg: syscon@...0000 {
> >  			compatible = "fsl,ls1028a-dcfg", "syscon";
> >  			reg = <0x0 0x1e00000 0x0 0x10000>;
> > -			big-endian;
> > +			little-endian;
> >  		};
> >
> >  		scfg: syscon@...0000 {
> > --
> > 2.17.1
> >