linux-kernel - Re: [PATCH] regulator: max77650: add of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MfUSJeNur3VpA7_=kSDpk1L83cK1+Tke3MPBZwfG9NubA@mail.gmail.com>
Date:   Tue, 10 Dec 2019 17:53:11 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Mark Brown <broonie@...nel.org>, Rob Herring <robh+dt@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH] regulator: max77650: add of_match table

wt., 10 gru 2019 o 14:21 Mark Brown <broonie@...nel.org> napisał(a):
>
> On Tue, Dec 10, 2019 at 02:10:15PM +0100, Bartosz Golaszewski wrote:
> > wt., 10 gru 2019 o 14:02 Mark Brown <broonie@...nel.org> napisał(a):
>
> > > This seems to work fine for other drivers and the platform bus has to be
> > > usable on systems that don't use DT so that doesn't sound right.  Which
> > > MODULE_ALIAS() are you using exactly?
>
> > MODULE_ALIAS("platform:max77650-regulator");
>
> Huh, that should work...  I wonder if adding a compatible to the DT has
> messed it up, does it work without the compatible in the .dts (and with
> the of_compatible removed from the MFD driver I guess)?
>

It does work when removing the compatible strings.

> > > > Besides: the DT bindings define the compatible for sub-nodes already.
> > > > We should probably conform to that.
>
> > > I would say that's a mistake and should be fixed, this particular way of
> > > loading the regulators is a Linux implementation detail.
>
> > Fixed by removing this from the bindings?
>
> Yeah.  Though it may be too late, shame I didn't catch this when it was
> merged :(

Yeah, I didn't know any better too.

Rob: the bindings for this were released some time ago and they define
compatible strings for MFD sub-nodes, but using compatible strings for
sub-nodes is apparently incorrect and the drivers don't support it
either. Can we remove them from the bindings?

Best regards,
Bartosz Golaszewski