linux-kernel - Re: [PATCH] regulator: max77650: add of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191210173701.GH6110@sirena.org.uk>
Date:   Tue, 10 Dec 2019 17:37:01 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH] regulator: max77650: add of_match table

On Tue, Dec 10, 2019 at 05:53:11PM +0100, Bartosz Golaszewski wrote:
> wt., 10 gru 2019 o 14:21 Mark Brown <broonie@...nel.org> napisał(a):
> > On Tue, Dec 10, 2019 at 02:10:15PM +0100, Bartosz Golaszewski wrote:
> > > wt., 10 gru 2019 o 14:02 Mark Brown <broonie@...nel.org> napisał(a):

> > > MODULE_ALIAS("platform:max77650-regulator");

> > Huh, that should work...  I wonder if adding a compatible to the DT has
> > messed it up, does it work without the compatible in the .dts (and with
> > the of_compatible removed from the MFD driver I guess)?

> It does work when removing the compatible strings.

Ah, that explains it.

> > Yeah.  Though it may be too late, shame I didn't catch this when it was
> > merged :(

> Yeah, I didn't know any better too.

> Rob: the bindings for this were released some time ago and they define
> compatible strings for MFD sub-nodes, but using compatible strings for
> sub-nodes is apparently incorrect and the drivers don't support it
> either. Can we remove them from the bindings?

I think at this point it's better to just keep compatibility rather than
disrupt anything, I'll go ahead and apply your patch.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)