linux-kernel - Re: [PATCH] ptp: clockmatrix: add I2C dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Dec 2019 20:11:25 +0000
From:   Vincent Cheng <vincent.cheng.xh@...esas.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Richard Cochran <richardcochran@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Yangbo Lu <yangbo.lu@....com>,
        Antonio Borneo <antonio.borneo@...com>,
        Thomas Gleixner <tglx@...utronix.de>,
        YueHaibing <yuehaibing@...wei.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ptp: clockmatrix: add I2C dependency

On Tue, Dec 10, 2019 at 02:56:34PM EST, Arnd Bergmann wrote:
>Without I2C, we get a link failure:
>
>drivers/ptp/ptp_clockmatrix.o: In function `idtcm_xfer.isra.3':
>ptp_clockmatrix.c:(.text+0xcc): undefined reference to `i2c_transfer'
>drivers/ptp/ptp_clockmatrix.o: In function `idtcm_driver_init':
>ptp_clockmatrix.c:(.init.text+0x14): undefined reference to `i2c_register_driver'
>drivers/ptp/ptp_clockmatrix.o: In function `idtcm_driver_exit':
>ptp_clockmatrix.c:(.exit.text+0x10): undefined reference to `i2c_del_driver'
>
>Fixes: 3a6ba7dc7799 ("ptp: Add a ptp clock driver for IDT ClockMatrix.")
>Signed-off-by: Arnd Bergmann <arnd@...db.de>
>---
> drivers/ptp/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
>index dc3d8ecb4231..e37797c0a85c 100644
>--- a/drivers/ptp/Kconfig
>+++ b/drivers/ptp/Kconfig
>@@ -107,7 +107,7 @@ config PTP_1588_CLOCK_KVM
> 
> config PTP_1588_CLOCK_IDTCM
> 	tristate "IDT CLOCKMATRIX as PTP clock"
>-	depends on PTP_1588_CLOCK
>+	depends on PTP_1588_CLOCK && I2C
> 	default n
> 	help
> 	  This driver adds support for using IDT CLOCKMATRIX(TM) as a PTP
>-- 

Sorry, that was flagged by "kbuild test robot" Nov 25.

I was in the process of creating a patch series with other updates,
but you beat me to the punch.  Thank-you.

Reviewed-by: Vincent Cheng  <vincent.cheng.xh@...esas.com>

Regards,
Vincent