linux-kernel - Re: [PATCH] cpu/SMT: fix x86 link error without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.1912102111480.4603@cbobk.fhfr.pm>
Date:   Tue, 10 Dec 2019 21:12:57 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
cc:     Thomas Gleixner <tglx@...utronix.de>, Pavel Machek <pavel@....cz>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        stable@...r.kernel.org,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Valentin Schneider <valentin.schneider@....com>,
        Zhenzhong Duan <zhenzhong.duan@...cle.com>,
        Tyler Hicks <tyhicks@...onical.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpu/SMT: fix x86 link error without CONFIG_SYSFS

On Tue, 10 Dec 2019, Arnd Bergmann wrote:

> When CONFIG_SYSFS is disabled, but CONFIG_HOTPLUG_SMT is enabled,
> the kernel fails to link:

I wonder where such kernels are running ... or I rather don't :)

> arch/x86/power/cpu.o: In function `hibernate_resume_nonboot_cpu_disable':
> (.text+0x38d): undefined reference to `cpuhp_smt_enable'
> arch/x86/power/hibernate.o: In function `arch_resume_nosmt':
> hibernate.c:(.text+0x291): undefined reference to `cpuhp_smt_enable'
> hibernate.c:(.text+0x29c): undefined reference to `cpuhp_smt_disable'
> 
> Move the exported functions out of the #ifdef section into its
> own with the correct conditions.
> 
> The patch that caused this is marked for stable backports, so
> this one may need to be backported as well.
> 
> Fixes: ec527c318036 ("x86/power: Fix 'nosmt' vs hibernation triple fault during resume")

Reviewed-by: Jiri Kosina <jkosina@...e.cz>

Thanks for fixing my oversight.

-- 
Jiri Kosina
SUSE Labs