linux-kernel - Re: [PATCH] staging: hp100: add back CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191210201318.GA4070187@kroah.com>
Date:   Tue, 10 Dec 2019 21:13:18 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Jaroslav Kysela <perex@...ex.cz>,
        Joe Perches <joe@...ches.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] staging: hp100: add back CONFIG_NET dependency

On Tue, Dec 10, 2019 at 09:00:52PM +0100, Arnd Bergmann wrote:
> The move to staging lost an important dependency:
> 
> ERROR: "eth_validate_addr" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "eth_mac_addr" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "alloc_etherdev_mqs" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "register_netdev" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "__skb_pad" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "consume_skb" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "dev_trans_start" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "__dev_kfree_skb_any" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "netif_rx" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "eth_type_trans" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "skb_trim" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "skb_put" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "__netdev_alloc_skb" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "free_netdev" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "unregister_netdev" [drivers/staging/hp/hp100.ko] undefined!
> 
> Add it back explicitly.
> 
> Fixes: 52340b82cf1a ("hp100: Move 100BaseVG AnyLAN driver to staging")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/staging/hp/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/hp/Kconfig b/drivers/staging/hp/Kconfig
> index fb395cfe6b92..9566d4ab5ce5 100644
> --- a/drivers/staging/hp/Kconfig
> +++ b/drivers/staging/hp/Kconfig
> @@ -6,6 +6,7 @@
>  config NET_VENDOR_HP
>  	bool "HP devices"
>  	default y
> +	depends on NET
>  	depends on ISA || EISA || PCI
>  	---help---
>  	  If you have a network (Ethernet) card belonging to this class, say Y.

Heh, I just queued up this same patch a few hours ago :)

greg k-h