linux-kernel - Re: [RFC PATCH] usb:gadget: Fixed issue with config_ep_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191210102231.GA3698263@kroah.com>
Date:   Tue, 10 Dec 2019 11:22:31 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jayshri Pawar <jpawar@...ence.com>
Cc:     linux-usb@...r.kernel.org, felipe.balbi@...ux.intel.com,
        heikki.krogerus@...ux.intel.com, rogerq@...com,
        linux-kernel@...r.kernel.org, jbergsagel@...com, nsekhar@...com,
        nm@...com, peter.chen@....com, kurahul@...ence.com,
        pawell@...ence.com, sparmar@...ence.com
Subject: Re: [RFC PATCH] usb:gadget: Fixed issue with config_ep_by_speed
 function.

On Mon, Dec 02, 2019 at 12:07:27PM +0100, Jayshri Pawar wrote:
>  /**
>   * config_ep_by_speed() - configures the given endpoint
> @@ -144,9 +146,11 @@ next_ep_desc(struct usb_descriptor_header **t)
>   */
>  int config_ep_by_speed(struct usb_gadget *g,
>  			struct usb_function *f,
> -			struct usb_ep *_ep)
> +			struct usb_ep *_ep,
> +			unsigned alt)

Why did you not document this new parameter?  It does not make sense to
me, what does it do, and how is it supposed to be used?

thanks,

greg k-h