linux-kernel - RE: [RFC PATCH] usb:gadget: Fixed issue with config_ep_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MN2PR07MB628834A5F09437CF742977D9C15B0@MN2PR07MB6288.namprd07.prod.outlook.com>
Date:   Tue, 10 Dec 2019 10:30:04 +0000
From:   Jayshri Dajiram Pawar <jpawar@...ence.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "felipe.balbi@...ux.intel.com" <felipe.balbi@...ux.intel.com>,
        "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
        "rogerq@...com" <rogerq@...com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jbergsagel@...com" <jbergsagel@...com>,
        "nsekhar@...com" <nsekhar@...com>, "nm@...com" <nm@...com>,
        "peter.chen@....com" <peter.chen@....com>,
        Rahul Kumar <kurahul@...ence.com>,
        Pawel Laszczak <pawell@...ence.com>,
        Sanket Parmar <sparmar@...ence.com>
Subject: RE: [RFC PATCH] usb:gadget: Fixed issue with config_ep_by_speed
 function.



> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Tuesday, December 10, 2019 3:53 PM
> To: Jayshri Dajiram Pawar <jpawar@...ence.com>
> Cc: linux-usb@...r.kernel.org; felipe.balbi@...ux.intel.com;
> heikki.krogerus@...ux.intel.com; rogerq@...com; linux-
> kernel@...r.kernel.org; jbergsagel@...com; nsekhar@...com; nm@...com;
> peter.chen@....com; Rahul Kumar <kurahul@...ence.com>; Pawel
> Laszczak <pawell@...ence.com>; Sanket Parmar <sparmar@...ence.com>
> Subject: Re: [RFC PATCH] usb:gadget: Fixed issue with config_ep_by_speed
> function.
> 
> EXTERNAL MAIL
> 
> 
> On Mon, Dec 02, 2019 at 12:07:27PM +0100, Jayshri Pawar wrote:
> >  /**
> >   * config_ep_by_speed() - configures the given endpoint @@ -144,9
> > +146,11 @@ next_ep_desc(struct usb_descriptor_header **t)
> >   */
> >  int config_ep_by_speed(struct usb_gadget *g,
> >  			struct usb_function *f,
> > -			struct usb_ep *_ep)
> > +			struct usb_ep *_ep,
> > +			unsigned alt)
> 
> Why did you not document this new parameter?  It does not make sense to
> me, what does it do, and how is it supposed to be used?
Hi Greg,
New parameter is documented and updated in patch v2.

Thanks,
Jayshri


> 
> thanks,
> 
> greg k-h