linux-kernel - Re: [PATCH] mmc: sdhci: Update the tuning failed messages to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFr-3RZUPS596HE2+Hu-FxhQ5e1Sv8DbeUtt5qLOjuxU8w@mail.gmail.com>
Date:   Tue, 10 Dec 2019 14:09:59 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Faiz Abbas <faiz_abbas@...com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH] mmc: sdhci: Update the tuning failed messages to pr_debug level

On Fri, 6 Dec 2019 at 12:42, Faiz Abbas <faiz_abbas@...com> wrote:
>
> Tuning support in DDR50 speed mode was added in SD Specifications Part1
> Physical Layer Specification v3.01. Its not possible to distinguish
> between v3.00 and v3.01 from the SCR and that is why since
> commit 4324f6de6d2e ("mmc: core: enable CMD19 tuning for DDR50 mode")
> tuning failures are ignored in DDR50 speed mode.
>
> Cards compatible with v3.00 don't respond to CMD19 in DDR50 and this
> error gets printed during enumeration and also if retune is triggered at
> any time during operation. Update the printk level to pr_debug so that
> these errors don't lead to false error reports.
>
> Signed-off-by: Faiz Abbas <faiz_abbas@...com>

Applied for fixes and by adding a stable tag, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 296d955ede59..42a9c8179da7 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2417,8 +2417,8 @@ static int __sdhci_execute_tuning(struct sdhci_host *host, u32 opcode)
>                 sdhci_send_tuning(host, opcode);
>
>                 if (!host->tuning_done) {
> -                       pr_info("%s: Tuning timeout, falling back to fixed sampling clock\n",
> -                               mmc_hostname(host->mmc));
> +                       pr_debug("%s: Tuning timeout, falling back to fixed sampling clock\n",
> +                                mmc_hostname(host->mmc));
>                         sdhci_abort_tuning(host, opcode);
>                         return -ETIMEDOUT;
>                 }
> --
> 2.19.2
>