linux-kernel - Re: [PATCH] tpm_tis: reserve chip for duration of tpm_tis_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Dec 2019 15:30:40 -0800
From:   Dan Williams <dan.j.williams@...el.com>
To:     Jerry Snitselaar <jsnitsel@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Christian Bundy <christianbundy@...ction.io>,
        Dan Williams <dan.j.williams@...el.com>,
        Peter Huewe <peterhuewe@....de>,
        Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Stefan Berger <stefanb@...ux.vnet.ibm.com>,
        stable <stable@...r.kernel.org>, linux-integrity@...r.kernel.org
Subject: Re: [PATCH] tpm_tis: reserve chip for duration of tpm_tis_core_init

On Wed, Dec 11, 2019 at 3:27 PM Jerry Snitselaar <jsnitsel@...hat.com> wrote:
>
> On Wed Dec 11 19, Jerry Snitselaar wrote:
> >Instead of repeatedly calling tpm_chip_start/tpm_chip_stop when
> >issuing commands to the tpm during initialization, just reserve the
> >chip after wait_startup, and release it when we are ready to call
> >tpm_chip_register.
> >
> >Cc: Christian Bundy <christianbundy@...ction.io>
> >Cc: Dan Williams <dan.j.williams@...el.com>
> >Cc: Peter Huewe <peterhuewe@....de>
> >Cc: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> >Cc: Jason Gunthorpe <jgg@...pe.ca>
> >Cc: Stefan Berger <stefanb@...ux.vnet.ibm.com>
> >Cc: stable@...r.kernel.org
> >Cc: linux-intergrity@...r.kernel.org
>
> Typo on the list address, do you want me to resend Jarkko?
>
> >Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()")
> >Signed-off-by: Jerry Snitselaar <jsnitsel@...hat.com>
> >---
>
> I did some initial testing with both a 1.2 device and a 2.0 device here.
> Christian, can you verify that this still solves your timeouts problem
> you were seeing? Dan, can you try this on the internal system with
> the interrupt issues? I will see if I can get the t490s owner to run
> it as well.

Will do. I assume you'd also want to add 'Fixes: 5b359c7c4372
("tpm_tis_core: Turn on the TPM before probing IRQ's")' if it works?