linux-kernel - Re: [PATCH v3 3/6] mfd: rn5t618: add irq support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191211124320.5744531f@kemnade.info>
Date:   Wed, 11 Dec 2019 12:43:20 +0100
From:   Andreas Kemnade <andreas@...nade.info>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     robh+dt@...nel.org, mark.rutland@....com, a.zummo@...ertech.it,
        alexandre.belloni@...tlin.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org,
        stefan@...er.ch, b.galvani@...il.com, phh@....me,
        letux-kernel@...nphoenux.org
Subject: Re: [PATCH v3 3/6] mfd: rn5t618: add irq support

On Wed, 11 Dec 2019 07:50:21 +0000
Lee Jones <lee.jones@...aro.org> wrote:

[...]
> > > > +
> > > >  static const struct i2c_device_id rn5t618_i2c_id[] = {
> > > >  	{ }
> > > >  };
> > > >  MODULE_DEVICE_TABLE(i2c, rn5t618_i2c_id);    
> > > 
> > > Not this patch I know, but it's strange to see this empty.  
> > 
> > Yes, should be cleaned up. For now the device tree stuff seems to kick in.  
> 
> I think this can be removed completely.
> 
> Just make sure you use .probe2 and it should be automatic.
> 
Hmm, I cannot find probe2 but probe_new. So you mean probe_new?

I will send a separate cleanup patch

Regards,
Andreas

Content of type "application/pgp-signature" skipped