linux-kernel - Re: [PATCH -next v2] pinctrl: samsung: fix build error without CONFIG_OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 12 Dec 2019 10:44:54 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Chen Zhou <chenzhou10@...wei.com>
Cc:     Tomasz Figa <tomasz.figa@...il.com>, s.nawrocki@...sung.com,
        linux-gpio@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next v2] pinctrl: samsung: fix build error without CONFIG_OF_GPIO

On Thu, 12 Dec 2019 at 10:38, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On Thu, 12 Dec 2019 at 10:30, Chen Zhou <chenzhou10@...wei.com> wrote:
> >
> > If CONFIG_OF_GPIO is n, build fails:
> >
> > drivers/pinctrl/samsung/pinctrl-samsung.c: In function samsung_gpiolib_register:
> > drivers/pinctrl/samsung/pinctrl-samsung.c:969:5: error: struct gpio_chip has no member named of_node
> >    gc->of_node = bank->of_node;
> >
> > Use #ifdef to guard this.
> >
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: Chen Zhou <chenzhou10@...wei.com>
> > ---
> >  drivers/pinctrl/samsung/pinctrl-samsung.c | 2 ++
> >  1 file changed, 2 insertions(+)
>
> I was thinking about adding OF_GPIO but I could not trigger such case
> as you mention. How can I reproduce this?

OK, I reproduced it with x86_64 + COMPILE_TEST + PINCTRL_S3C64XX. I'll
fix it up with proper dependencies on OF and GPIOLIB. The driver
should not have unnecessary ifdefs.

Thanks for the report!

Best regards,
Krzysztof