linux-kernel - Re: [PATCH] clk: meson: g12a: fix missing uart2 in regmap table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Dec 2019 11:34:28 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Jerome Brunet <jbrunet@...libre.com>
Cc:     Kevin Hilman <khilman@...libre.com>,
        linux-amlogic@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, Dmitry Shmidt <dimitrysh@...gle.com>
Subject: Re: [PATCH] clk: meson: g12a: fix missing uart2 in regmap table

On 13/12/2019 11:33, Jerome Brunet wrote:
> UART2 peripheral is missing from the regmap fixup table of the g12a family
> clock controller. As it is, any access to this clock would Oops, which is
> not great.
> 
> Add the clock to the table to fix the problem.
> 
> Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
> Reported-by: Dmitry Shmidt <dimitrysh@...gle.com>
> Tested-by: Dmitry Shmidt <dimitrysh@...gle.com>
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>
> ---
>  drivers/clk/meson/g12a.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
> index 66cf791bfc8c..cd1de3e004e4 100644
> --- a/drivers/clk/meson/g12a.c
> +++ b/drivers/clk/meson/g12a.c
> @@ -4692,6 +4692,7 @@ static struct clk_regmap *const g12a_clk_regmaps[] = {
>  	&g12a_bt656,
>  	&g12a_usb1_to_ddr,
>  	&g12a_mmc_pclk,
> +	&g12a_uart2,
>  	&g12a_vpu_intr,
>  	&g12a_gic,
>  	&g12a_sd_emmc_a_clk0,
> 

Acked-by: Neil Armstrong <narmstrong@...libre.com>