linux-kernel - Re: [PATCH] MAINTAINERS: rockchip: Track more files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191213113528.2e06e1f4@xps13>
Date:   Fri, 13 Dec 2019 11:35:28 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Heiko Stuebner <heiko@...ech.de>
Cc:     Kever Yang <kever.yang@...k-chips.com>,
        linux-rockchip@...ts.infradead.org,
        Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
        linux-kernel@...r.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH] MAINTAINERS: rockchip: Track more files

Hi Heiko,

Heiko Stuebner <heiko@...ech.de> wrote on Fri, 13 Dec 2019 11:27:29
+0100:

> Am Montag, 9. Dezember 2019, 09:18:00 CET schrieb Kever Yang:
> > Hi Miquel,
> > 
> > On 2019/12/4 下午5:07, Miquel Raynal wrote:  
> > > The current list misses a lot of drivers not prefixed or suffixed by
> > > "rockchip". For instance, there are plenty drivers called rk808 and
> > > rk805 which are currently not tracked (clk, regulator, pinctrl, RTC,
> > > MFD, includes, bindings). Add them to the list under the Rockchip
> > > entry.
> > >
> > > Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
> > > ---
> > >
> > > Hi Heiko,
> > >
> > > You are right we should try to check more often your tree. Also, here
> > > is a patch so that you are Cc'ed for all Rockchip related patches
> > > because the current list is not exhaustive at all (not sure it is
> > > voluntary or not though).
> > >
> > > Cheers,
> > > Miquèl
> > >
> > >   MAINTAINERS | 4 ++++
> > >   1 file changed, 4 insertions(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index cba1095547fd..a9564e6cb872 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -2198,12 +2198,16 @@ L:	linux-rockchip@...ts.infradead.org
> > >   T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git
> > >   S:	Maintained
> > >   F:	Documentation/devicetree/bindings/i2c/i2c-rk3x.txt
> > > +F:	Documentation/devicetree/bindings/*/*rk80*
> > >   F:	arch/arm/boot/dts/rk3*
> > >   F:	arch/arm/boot/dts/rv1108*
> > >   F:	arch/arm/mach-rockchip/
> > > +F:	include/*/*/rk808.h
> > > +F:	include/*/*/*/rk808.h
> > >   F:	drivers/clk/rockchip/
> > >   F:	drivers/i2c/busses/i2c-rk3x.c
> > >   F:	drivers/*/*rockchip*
> > > +F:	drivers/*/*rk80*
> > >   F:	drivers/*/*/*rockchip*
> > >   F:	sound/soc/rockchip/
> > >   N:	rockchip  
> > For the Rockchip PMIC, is it better to have a NEW MAINTAINER entry like 
> > "ROCKCHIP PMIC DRIVER"
> > which share the same mailing list linux-rockchip@, because there is not 
> > only rk808,
> > but also rk805, rk809, rk817, rk818, and may be more to come.
> > 
> > BTW, we should use 'rk8' instead of 'rk80' to match all the Rockchip PMICs.  
> 
> yep, I agree with Kever on this ... also that new pmic-related entry should
> not really link to a git tree as patches for it will get distributed through
> multiple trees (mfd, regulator, rtc) most of the time.

I think it is important that the maintainer receive all Rockchip
related patches, as he has the bigger picture in mind. Of course it is
possible to add an additional MAINTAINER entry for Rockchip PMIC
drivers specifically.

So in the end, I will s/rk80/rk8/, shall I remove a specific entry from
the 4 added?

> 
> Miquel can you do a v2 please?

Of course, this is planned, I'm just a bit late in my e-mail backlog!

Cheers,
Miquèl