linux-kernel - Re: [PATCH 33/58] serial/f81534: Don't check port->sysrq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191216121050.GD22665@localhost>
Date:   Mon, 16 Dec 2019 13:10:50 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Dmitry Safonov <dima@...sta.com>
Cc:     linux-kernel@...r.kernel.org,
        Dmitry Safonov <0x7f454c46@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        Vasiliy Khoruzhick <vasilykh@...sta.com>,
        linux-serial@...r.kernel.org
Subject: Re: [PATCH 33/58] serial/f81534: Don't check port->sysrq

On Fri, Dec 13, 2019 at 12:06:32AM +0000, Dmitry Safonov wrote:
> usb_serial_handle_sysrq_char() already checks it.
> 
> Signed-off-by: Dmitry Safonov <dima@...sta.com>
> ---
>  drivers/usb/serial/f81534.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/serial/f81534.c b/drivers/usb/serial/f81534.c
> index 2b39bda035c7..67a8e343eba1 100644
> --- a/drivers/usb/serial/f81534.c
> +++ b/drivers/usb/serial/f81534.c
> @@ -1238,10 +1238,8 @@ static void f81534_process_per_serial_block(struct usb_serial_port *port,
>  			schedule_work(&port_priv->lsr_work);
>  		}
>  
> -		if (port->port.console && port->sysrq) {
> -			if (usb_serial_handle_sysrq_char(port, data[i]))
> -				continue;
> -		}
> +		if (usb_serial_handle_sysrq_char(port, data[i]))
> +			continue;

This is unrelated to the rest of the series.

Please break all usb-serial patches out of this series and submit them
to me and the usb list for review.

Johan