linux-kernel - Re: [PATCH 33/58] serial/f81534: Don't check port->sysrq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8318fa54-91c5-7c7b-cc97-53dd34c617e2@arista.com>
Date:   Mon, 16 Dec 2019 16:36:56 +0000
From:   Dmitry Safonov <dima@...sta.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Dmitry Safonov <0x7f454c46@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        Vasiliy Khoruzhick <vasilykh@...sta.com>,
        linux-serial@...r.kernel.org
Subject: Re: [PATCH 33/58] serial/f81534: Don't check port->sysrq

Hi Johan,

On 12/16/19 12:10 PM, Johan Hovold wrote:
> On Fri, Dec 13, 2019 at 12:06:32AM +0000, Dmitry Safonov wrote:
>> -		if (port->port.console && port->sysrq) {
>> -			if (usb_serial_handle_sysrq_char(port, data[i]))
>> -				continue;
>> -		}
>> +		if (usb_serial_handle_sysrq_char(port, data[i]))
>> +			continue;
> 
> This is unrelated to the rest of the series.

Right, will drop it from v2.

> 
> Please break all usb-serial patches out of this series and submit them
> to me and the usb list for review.
Thanks,
          Dmitry