linux-kernel - Re: [PATCH v4 1/3] tty: rename tty_kopen() and add new function tty_kopen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191217202353.GA4140500@kroah.com>
Date:   Tue, 17 Dec 2019 21:23:53 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Jacek Anaszewski <jacek.anaszewski@...il.com>
Cc:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, Pavel Machek <pavel@....cz>,
        Dan Murphy <dmurphy@...com>, Jiri Slaby <jslaby@...e.com>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...gutronix.de, linux-serial@...r.kernel.org
Subject: Re: [PATCH v4 1/3] tty: rename tty_kopen() and add new function
 tty_kopen_shared()

On Tue, Dec 17, 2019 at 09:19:38PM +0100, Jacek Anaszewski wrote:
> On 12/17/19 7:27 PM, Uwe Kleine-König wrote:
> > Hello Jacek,
> > 
> > On Tue, Dec 17, 2019 at 07:08:47PM +0100, Jacek Anaszewski wrote:
> >> I wanted to test the set but unfortunately this
> >> patch does not apply. See below for the apparent reason.
> >>
> >>> [...]
> >>> -struct tty_struct *tty_kopen(dev_t device)
> >>> +static struct tty_struct *tty_kopen(dev_t device, int shared)
> >>>  {
> >>>  	struct tty_struct *tty;
> >>>  	struct tty_driver *driver;
> >>
> >> In mainline, even in v5.5-rc2 we have here NULL assignment:
> >>
> >> struct tty_driver *driver = NULL;
> > 
> > Yeah, if you don't want to wait for Greg's tree to appear in next, this
> > is the patch you're missing:
> > 
> > 	https://lkml.org/lkml/2019/12/17/101
> 
> Thanks for the pointer.
> 
> And regarding the trigger - I've tried below use case
> on my desktop Debian:
> 
> Ctrl+Alt+F3 to change the console
> 
> Then logged in and executed tty command:
> 
> $ tty
> $ /dev/tty3
> 
> $ cd /sys/class/leds/input5\:\:capslock
> note: this is LED on my USB keyboard and it works correct
> with e.g. timer trigger
> 
> /sys/class/leds/input5::capslock$ echo tty > trigger
> 
> $ cat /sys/class/tty/tty3/dev > dev
> 
> Type some characters.
> 
> LED does not blink.
> 
> $ echo "aaa" > /dev/tty3
> $ aaa
> 
> LED also does not blink.
> 
> I assume this is correct test case for tty trigger?

Try it on a real serial port, tty3 is a virtual one and I do not think
the "transmit/receive" statistics are every updated on a virtual one as
it does not make any sense to do so.

thanks,

greg k-h