linux-kernel - Re: [PATCH 4/5] init: unify opening /dev/console as stdin/stdout/stderr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191217064254.GB3247@light.dominikbrodowski.net>
Date:   Tue, 17 Dec 2019 07:42:54 +0100
From:   Dominik Brodowski <linux@...inikbrodowski.net>
To:     youling257 <youling257@...il.com>
Cc:     viro@...iv.linux.org.uk, torvalds@...ux-foundation.org,
        gregkh@...uxfoundation.org, rafael@...nel.org,
        akpm@...ux-foundation.org, mingo@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] init: unify opening /dev/console as
 stdin/stdout/stderr

On Tue, Dec 17, 2019 at 01:17:51PM +0800, youling257 wrote:
> it caused Androidx86 /system/bin/sh: No controlling tty: open /dev/tty: No such device or address
> /system/bin/sh: warning: won't have full job control
> 
> Androidx86 alt+f1 root on tmpfs, alt+f2/f3 root on rootfs.

Are you sure it is caused by the patch you reference? It's really only
moving code around, and does not depend on tmpfs/rootfs. The exact same
three calls are made before and after the change, see
	https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b49a733d684e0096340b93e9dfd471f0e3ddc06d

The preceding patch (3/5) needs a bugfix which already is upstream, though.
	https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7de7de7ca0ae0fc70515ee3154af33af75edae2c

Thanks,
	Dominik