linux-kernel - Re: [PATCH 4/5] init: unify opening /dev/console as stdin/stdout/stderr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOzgRda=q0mBeBx_i8N0VT_a_ud8EVcf9hVC5Y_Oz2sdAdGGLg@mail.gmail.com>
Date:   Wed, 18 Dec 2019 12:10:08 +0800
From:   youling 257 <youling257@...il.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Dominik Brodowski <linux@...inikbrodowski.net>,
        Al Viro <viro@...iv.linux.org.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rafael Wysocki <rafael@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Ingo Molnar <mingo@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/5] init: unify opening /dev/console as stdin/stdout/stderr

only Revert "fs: remove ksys_dup()", not see the warning
"/system/bin/sh: No controlling tty: open /dev/tty: No such device or
address."

yes, "fs: remove ksys_dup()" caused my system/bin/sh problem.

but test "early init: fix error handling when opening /dev/console",
still can see "/system/bin/sh: No controlling tty" warning, it not
solve my problem.


2019-12-18 5:14 GMT+08:00, Linus Torvalds <torvalds@...ux-foundation.org>:
> This should be fixed by 2d3145f8d280 ("early init: fix error handling
> when opening /dev/console")
>
> I'm not sure what you did to trigger that bug, but it was a bug.
>
>               Linus
>
>
> On Tue, Dec 17, 2019 at 1:34 AM youling 257 <youling257@...il.com> wrote:
>>
>> I had been Revert "fs: remove ksys_dup()" Revert "init: unify opening
>> /dev/console as stdin/stdout/stderr", test boot, n the system/bin/sh
>> warning.
>