linux-kernel - Re: [PATCH 4/5] init: unify opening /dev/console as stdin/stdout/stderr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191218080347.GA324400@light.dominikbrodowski.net>
Date:   Wed, 18 Dec 2019 09:03:47 +0100
From:   Dominik Brodowski <linux@...inikbrodowski.net>
To:     youling 257 <youling257@...il.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rafael Wysocki <rafael@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Ingo Molnar <mingo@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/5] init: unify opening /dev/console as
 stdin/stdout/stderr

On Wed, Dec 18, 2019 at 12:10:08PM +0800, youling 257 wrote:
> only Revert "fs: remove ksys_dup()", not see the warning
> "/system/bin/sh: No controlling tty: open /dev/tty: No such device or
> address."
> 
> yes, "fs: remove ksys_dup()" caused my system/bin/sh problem.
> 
> but test "early init: fix error handling when opening /dev/console",
> still can see "/system/bin/sh: No controlling tty" warning, it not
> solve my problem.

FWIW, I see a similar (seemingly harmless) warning both _before_ and
after my patches, so I am not sure that this is a real regression.

Thanks,
	Dominik