linux-kernel - Re: [PATCH] arm: dts: imx7ulp: fix reg of cpu node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lfr9suoy.fsf@tarshish>
Date:   Wed, 18 Dec 2019 14:07:57 +0200
From:   Baruch Siach <baruch@...s.co.il>
To:     linux-arm-kernel@...ts.infradead.org
Cc:     "robh+dt\@kernel.org" <robh+dt@...nel.org>,
        "mark.rutland\@arm.com" <mark.rutland@....com>,
        "shawnguo\@kernel.org" <shawnguo@...nel.org>,
        "kernel\@pengutronix.de" <kernel@...gutronix.de>,
        "festevam\@gmail.com" <festevam@...il.com>,
        Aisheng Dong <aisheng.dong@....com>,
        "devicetree\@vger.kernel.org" <devicetree@...r.kernel.org>,
        Peng Fan <peng.fan@....com>, Alice Guo <alice.guo@....com>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH] arm: dts: imx7ulp: fix reg of cpu node

Hi Peng,

On Wed, Dec 18 2019, Peng Fan wrote:
> From: Peng Fan <peng.fan@....com>
>
> According to arm cpus binding doc,
> "
>       On 32-bit ARM v7 or later systems this property is
>         required and matches the CPU MPIDR[23:0] register
>         bits.
>
>         Bits [23:0] in the reg cell must be set to
>         bits [23:0] in MPIDR.
>
>         All other bits in the reg cell must be set to 0.
> "
>
> In i.MX7ULP, the MPIDR[23:0] is 0xf00, not 0, so fix it.
> Otherwise there will be warning:
> "DT missing boot CPU MPIDR[23:0], fall back to default cpu_logical_map"
>
> Fixes: 20434dc92c05 ("ARM: dts: imx: add common imx7ulp dtsi support")
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>  arch/arm/boot/dts/imx7ulp.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
> index d37a1927c88e..aa9e50178d6b 100644
> --- a/arch/arm/boot/dts/imx7ulp.dtsi
> +++ b/arch/arm/boot/dts/imx7ulp.dtsi
> @@ -40,7 +40,7 @@
>  		cpu0: cpu@0 {

The address suffix in the node name should update to match 'reg'.

>  			compatible = "arm,cortex-a7";
>  			device_type = "cpu";
> -			reg = <0>;
> +			reg = <0xf00>;
>  		};
>  	};

baruch

--
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -