linux-kernel - Re: [PATCH] hid: hid-picolcd: fix possible sleep-in-atomic-context bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e36ad913-c498-4d5a-0a5a-bec016d49a16@gmail.com>
Date:   Wed, 18 Dec 2019 20:11:47 +0800
From:   Jia-Ju Bai <baijiaju1990@...il.com>
To:     Bruno Prémont <bonbons@...ux-vserver.org>
Cc:     jikos@...nel.org, benjamin.tissoires@...hat.com,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hid: hid-picolcd: fix possible sleep-in-atomic-context
 bug

Thanks for the reply.

On 2019/12/18 16:41, Bruno Prémont wrote:
> Hi Jia-Ju,
>
> Your checker has been looking at fallback implementation for
> the might-sleep hid_alloc_report_buf(GFP_KERNEL).
>
> Did you have a look at the low-lever bus-driver implementations:
>    hdev->ll_driver->request
>                     ^^^^^^^
>
> Are those all sleeping as well or maybe they don't sleep?\

In fact, I find that a function possibly-related to this function 
pointer can sleep:

drivers/hid/intel-ish-hid/ishtp-hid.c, 97:
     kzalloc(GFP_KERNEL) in ishtp_hid_request

But I am not quite sure whether this function is really referenced by 
the function pointer, so I did not report it.


Best wishes,
Jia-Ju Bai