linux-kernel - Re: [PATCH v2] power: reset: gpio-restart: don't error on deferral

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Dec 2019 01:16:22 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] power: reset: gpio-restart: don't error on deferral

Hi,

On Wed, Oct 30, 2019 at 09:17:26AM +1300, Chris Packham wrote:
> Don't generate an error message when devm_gpiod_get fails with
> -EPROBE_DEFER.
> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> ---

Thanks, queued to power-supply's for-next branch.

-- Sebastian

> 
> Notes:
>     Changes in v2:
>     - use PTR_ERR_OR_ZERO() to avoid excessive PTR_ERR()
> 
>  drivers/power/reset/gpio-restart.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/power/reset/gpio-restart.c b/drivers/power/reset/gpio-restart.c
> index 308ca9d9d276..5466eeea261c 100644
> --- a/drivers/power/reset/gpio-restart.c
> +++ b/drivers/power/reset/gpio-restart.c
> @@ -64,9 +64,11 @@ static int gpio_restart_probe(struct platform_device *pdev)
>  
>  	gpio_restart->reset_gpio = devm_gpiod_get(&pdev->dev, NULL,
>  			open_source ? GPIOD_IN : GPIOD_OUT_LOW);
> -	if (IS_ERR(gpio_restart->reset_gpio)) {
> -		dev_err(&pdev->dev, "Could not get reset GPIO\n");
> -		return PTR_ERR(gpio_restart->reset_gpio);
> +	ret = PTR_ERR_OR_ZERO(gpio_restart->reset_gpio);
> +	if (ret) {
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(&pdev->dev, "Could not get reset GPIO\n");
> +		return ret;
>  	}
>  
>  	gpio_restart->restart_handler.notifier_call = gpio_restart_notify;
> -- 
> 2.23.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)