linux-kernel - Re: [PATCH] power: supply: pda_power: add missed usb_unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Dec 2019 01:17:06 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Chuhong Yuan <hslester96@...il.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: pda_power: add missed
 usb_unregister_notifier

Hi,

On Fri, Nov 15, 2019 at 02:25:15PM +0800, Chuhong Yuan wrote:
> The driver forgets to unregister the notifier in remove.
> Add the call to fix it.
> 
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>
> ---

Thanks, queued to power-supply's for-next branch.

-- Sebastian

>  drivers/power/supply/pda_power.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/power/supply/pda_power.c b/drivers/power/supply/pda_power.c
> index 3ae5707d39fa..03a37fd6be27 100644
> --- a/drivers/power/supply/pda_power.c
> +++ b/drivers/power/supply/pda_power.c
> @@ -429,6 +429,10 @@ static int pda_power_probe(struct platform_device *pdev)
>  
>  static int pda_power_remove(struct platform_device *pdev)
>  {
> +#if IS_ENABLED(CONFIG_USB_PHY)
> +	if (!IS_ERR_OR_NULL(transceiver) && pdata->use_otg_notifier)
> +		usb_unregister_notifier(transceiver, &otg_nb);
> +#endif
>  	if (pdata->is_usb_online && usb_irq)
>  		free_irq(usb_irq->start, pda_psy_usb);
>  	if (pdata->is_ac_online && ac_irq)
> -- 
> 2.24.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)