linux-kernel - Re: [PATCH] serdev: Don't claim unsupported serial devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87eex1noak.fsf@kokedama.swc.toshiba.co.jp>
Date:   Thu, 19 Dec 2019 09:37:23 +0900
From:   Punit Agrawal <punit1.agrawal@...hiba.co.jp>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     linux-serial@...r.kernel.org, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org, nobuhiro1.iwamatsu@...hiba.co.jp,
        shrirang.bagul@...onical.com, stable@...r.kernel.org,
        Rob Herring <robh@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH] serdev: Don't claim unsupported serial devices

Hans de Goede <hdegoede@...hat.com> writes:

> Hi,
>
> On 18-12-2019 07:56, Punit Agrawal wrote:
>> Serdev sub-system claims all serial devices that are not already
>> enumerated. As a result, no device node is created for serial port on
>> certain boards such as the Apollo Lake based UP2. This has the
>> unintended consequence of not being able to raise the login prompt via
>> serial connection.
>>
>> Introduce a blacklist to reject devices that should not be treated as
>> a serdev device. Add the Intel HS UART peripheral ids to the blacklist
>> to bring back serial port on SoCs carrying them.
>>
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Punit Agrawal <punit1.agrawal@...hiba.co.jp>
>> Cc: Rob Herring <robh@...nel.org>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Cc: Johan Hovold <johan@...nel.org>
>> Cc: Hans de Goede <hdegoede@...hat.com>
>
> Thank you for addressing this long standing issue.

I am surprised there hasn't been more people complaining! Maybe even on
x86 mainline isn't that widely used on development boards.

> The basic approach here looks good to me, once the minor
> comments from other reviewers are addressed you can add my:
>
> Acked-by: Hans de Goede <hdegoede@...hat.com>

Thanks!

[...]