linux-kernel - Re: [PATCH AUTOSEL 5.4 019/350] iio: tcs3414: fix iio_triggered_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191219152228.GK17708@sasha-vm>
Date:   Thu, 19 Dec 2019 10:22:28 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Jonathan Cameron <jic23@...23.retrosnub.co.uk>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Alexandru Ardelean <alexandru.ardelean@...log.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        linux-iio@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 5.4 019/350] iio: tcs3414: fix
 iio_triggered_buffer_{pre,post}enable positions

On Sun, Dec 15, 2019 at 03:52:03PM +0000, Jonathan Cameron wrote:
>On Tue, 10 Dec 2019 15:58:31 -0500
>Sasha Levin <sashal@...nel.org> wrote:
>
>> From: Alexandru Ardelean <alexandru.ardelean@...log.com>
>>
>> [ Upstream commit 0fe2f2b789190661df24bb8bf62294145729a1fe ]
>>
>> The iio_triggered_buffer_{predisable,postenable} functions attach/detach
>> the poll functions.
>>
>> For the predisable hook, the disable code should occur before detaching
>> the poll func, and for the postenable hook, the poll func should be
>> attached before the enable code.
>>
>> The driver was slightly reworked. The preenable hook was moved to the
>> postenable, to add some symmetry to the postenable/predisable part.
>>
>> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
>> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>I doubt this did any harm, but wouldn't consider it stable material normally.
>
>This is part of a general rework going on to allow some core refactoring.
>
>I should have added a note to this one like some related patches that it
>is a logical fix, but we don't have an actual known bug afaik.

I'll drop it from everywhere, thanks!

-- 
Thanks,
Sasha