linux-kernel - Re: [PATCH AUTOSEL 5.4 025/350] objtool: add kunit_try_catch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191219152718.GL17708@sasha-vm>
Date:   Thu, 19 Dec 2019 10:27:18 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Brendan Higgins <brendanhiggins@...gle.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        stable@...r.kernel.org, kbuild test robot <lkp@...el.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH AUTOSEL 5.4 025/350] objtool: add kunit_try_catch_throw
 to the noreturn list

On Tue, Dec 10, 2019 at 01:25:54PM -0800, Brendan Higgins wrote:
>On Tue, Dec 10, 2019 at 1:04 PM Sasha Levin <sashal@...nel.org> wrote:
>>
>> From: Brendan Higgins <brendanhiggins@...gle.com>
>>
>> [ Upstream commit 33adf80f5b52e3f7c55ad66ffcaaff93c6888aaa ]
>>
>> Fix the following warning seen on GCC 7.3:
>>   kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch()
>>
>> kunit_try_catch_throw is a function added in the following patch in this
>> series; it allows KUnit, a unit testing framework for the kernel, to
>> bail out of a broken test. As a consequence, it is a new __noreturn
>> function that objtool thinks is broken (as seen above). So fix this
>> warning by adding kunit_try_catch_throw to objtool's noreturn list.
>>
>> Reported-by: kbuild test robot <lkp@...el.com>
>> Signed-off-by: Brendan Higgins <brendanhiggins@...gle.com>
>> Acked-by: Josh Poimboeuf <jpoimboe@...hat.com>
>> Link: https://www.spinics.net/lists/linux-kbuild/msg21708.html
>> Cc: Peter Zijlstra <peterz@...radead.org>
>> Signed-off-by: Shuah Khan <skhan@...uxfoundation.org>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>
>I don't think this change should be backported. This patch is to
>ignore an erroneous warning introduced by KUnit; it serves no purpose
>prior to the KUnit patches being merged.

I'll drop it, thanks!

-- 
Thanks,
Sasha