[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <398f514a-e2ce-8b4f-16cf-4edeec5fa1e7@kernel.dk>
Date: Fri, 20 Dec 2019 16:48:48 -0700
From: Jens Axboe <axboe@...nel.dk>
To: Colin King <colin.king@...onical.com>,
Alexander Viro <viro@...iv.linux.org.uk>,
io-uring@...r.kernel.org, linux-fsdevel@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] io_uring: fix missing error return when
percpu_ref_init fails
On 12/20/19 4:33 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> Currently when the call to percpu_ref_init fails ctx->file_data is
> set to null and because there is a missing return statement the
> following statement dereferences this null pointer causing an oops.
> Fix this by adding the missing -ENOMEM return to avoid the oops.
Nice, thanks! I'm guessing I didn't have the necessary magic debug
options to allow failure injection for failing.
--
Jens Axboe
Powered by blists - more mailing lists