[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cf270359-fd06-3175-d0ef-ec2adc628235@canonical.com>
Date: Fri, 20 Dec 2019 23:49:49 +0000
From: Colin Ian King <colin.king@...onical.com>
To: Jens Axboe <axboe@...nel.dk>,
Alexander Viro <viro@...iv.linux.org.uk>,
io-uring@...r.kernel.org, linux-fsdevel@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] io_uring: fix missing error return when
percpu_ref_init fails
On 20/12/2019 23:48, Jens Axboe wrote:
> On 12/20/19 4:33 PM, Colin King wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> Currently when the call to percpu_ref_init fails ctx->file_data is
>> set to null and because there is a missing return statement the
>> following statement dereferences this null pointer causing an oops.
>> Fix this by adding the missing -ENOMEM return to avoid the oops.
>
> Nice, thanks! I'm guessing I didn't have the necessary magic debug
> options to allow failure injection for failing.
Fortunately we have Coverity to the rescue :-)
Colin
Powered by blists - more mailing lists