linux-kernel - Re: [PATCH] x86/resctrl: Fix potential memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Dec 2019 21:46:40 -0800
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Shakeel Butt <shakeelb@...gle.com>
Cc:     Fenghua Yu <fenghua.yu@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/resctrl: Fix potential memory leak

Hi Shakeel,

On 12/19/2019 5:54 PM, Shakeel Butt wrote:
> On Thu, Dec 19, 2019 at 3:27 PM Reinette Chatre
> <reinette.chatre@...el.com> wrote:
>> On 12/19/2019 2:38 PM, Shakeel Butt wrote:
>>> The set_cache_qos_cfg() is leaking memory when the given level is not
>>> RDT_RESOURCE_L3 or RDT_RESOURCE_L2. Fix that.
>>
>> I think it would be valuable to those considering whether they need to
>> backport to know that RDT_RESOURCE_L3 and RDT_RESOURCE_L2 are currently
>> the only possible levels with which this function is called. It is thus
>> not currently possible for this leak to occur. Indeed a valuable safety
>> to add in case this code may change in the future. Thank you very much.
>>
> 
> Do you want me to add that info the commit and resend the v2 of the patch?
> 

Yes please.

Thank you very much

Reinette