[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CALvZod7zi+t9A=4_L-iiD3JhFpGU0Jt-=Q1_ee=7=7KAUMykVA@mail.gmail.com>
Date: Thu, 19 Dec 2019 17:54:05 -0800
From: Shakeel Butt <shakeelb@...gle.com>
To: Reinette Chatre <reinette.chatre@...el.com>
Cc: Fenghua Yu <fenghua.yu@...el.com>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
x86@...nel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/resctrl: Fix potential memory leak
On Thu, Dec 19, 2019 at 3:27 PM Reinette Chatre
<reinette.chatre@...el.com> wrote:
>
> Hi Shakeel,
>
> On 12/19/2019 2:38 PM, Shakeel Butt wrote:
> > The set_cache_qos_cfg() is leaking memory when the given level is not
> > RDT_RESOURCE_L3 or RDT_RESOURCE_L2. Fix that.
>
> I think it would be valuable to those considering whether they need to
> backport to know that RDT_RESOURCE_L3 and RDT_RESOURCE_L2 are currently
> the only possible levels with which this function is called. It is thus
> not currently possible for this leak to occur. Indeed a valuable safety
> to add in case this code may change in the future. Thank you very much.
>
Do you want me to add that info the commit and resend the v2 of the patch?
Powered by blists - more mailing lists