linux-kernel - Re: [PATCH] nvmem: add QTI SDAM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191220002929.GJ448416@yoga>
Date:   Thu, 19 Dec 2019 16:29:29 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     sthella@...eaurora.org
Cc:     srinivas.kandagatla@...aro.org, agross@...nel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] nvmem: add QTI SDAM driver

On Thu 19 Dec 02:29 PST 2019, sthella@...eaurora.org wrote:

> On 2019-12-18 11:44, Bjorn Andersson wrote:
> > On Tue 17 Dec 01:20 PST 2019, Shyam Kumar Thella wrote:
[..]
> > > +subsys_initcall(sdam_init);
> > 
> > module_platform_driver(sdam_driver), unless you have some strong
> > arguments for why this needs to be subsys_initcall
> There are some critical sybsystems which depend on nvmem data. So I would
> prefer using subsys_initcall().

How critical? Needed to kernel module loading?

Can you please document this need somehow? (either a comment here or
something in the commit message). Be specific.

THanks,
Bjorn